Fixes for missing localIds #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce and only once
|
Formatting check succeeded! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
============================================
+ Coverage 62.70% 62.79% +0.09%
- Complexity 6079 6090 +11
============================================
Files 466 468 +2
Lines 25308 25322 +14
Branches 4711 4714 +3
============================================
+ Hits 15869 15901 +32
+ Misses 7288 7280 -8
+ Partials 2151 2141 -10 ☔ View full report in Codecov by Sentry. |
Capt-Mac
approved these changes
Dec 22, 2023
barhodes
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a refactor to separate and reorder the phases of the compiler, which can be seen here:
https://github.com/cqframework/clinical_quality_language/blob/bug-localId-tests/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/CqlCompiler.java#L208-L241
Resolves #1295, #1279, #1131, #704, #697